Add discovery-ec2 integration test for AZ attr
#118452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verifies that the plugin sets the `aws_availability_zone` automatically by reading the AZ name from the IMDS at startup.
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
added
the
auto-backport
DaveCTurner
commented
Dec 11, 2024
| import java.util.function.BiConsumer; | ||
| import java.util.function.Supplier; | ||
|
|
||
| public class Ec2ImdsServiceBuilder { |
Contributor
Author
There was a problem hiding this comment.
Most of this change is moving the creation of the Ec2ImdsHttpHandler from a regular constructor with an increasing parameter list (most of which will be a sensible default value) into this builder. Not obviously all that important when there's only 4 params, but more are on their way soon enough.
pxsalehi
approved these changes
Dec 12, 2024
DaveCTurner
deleted the
2024/12/11/discovery-ec2-availability-zone-tests
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Dec 12, 2024
Verifies that the plugin sets the `aws_availability_zone` automatically by reading the AZ name from the IMDS at startup.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 12, 2024
Verifies that the plugin sets the `aws_availability_zone` automatically by reading the AZ name from the IMDS at startup.
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
…astic#118541) Verifies that the plugin sets the `aws_availability_zone` automatically by reading the AZ name from the IMDS at startup.
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
…astic#118541) Verifies that the plugin sets the `aws_availability_zone` automatically by reading the AZ name from the IMDS at startup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifies that the plugin sets the
aws_availability_zonenode attributeautomatically by reading the AZ name from the IMDS at startup.