Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
dc611ab
Fix wildcard field-caps for LOOKUP JOIN
craigtaverner Dec 11, 2024
85d3362
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 11, 2024
e3ae17a
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 11, 2024
ce99649
Add support for multiple lookup joins
craigtaverner Dec 11, 2024
3039387
Ignore two remaining failures
craigtaverner Dec 11, 2024
0af4dc5
Revert some formatting changes
craigtaverner Dec 11, 2024
c7a09b8
Fix compile errors
craigtaverner Dec 11, 2024
19a3cdb
Merge branch 'fix-lookupjoin-wildcard-fieldcaps' of github.com:craigt…
craigtaverner Dec 11, 2024
5c188a3
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 11, 2024
3649261
More consistent test naming
craigtaverner Dec 11, 2024
96b97ce
More consistent test naming
craigtaverner Dec 11, 2024
e60a216
Change EsqlCapability for backwards compatibility tests
craigtaverner Dec 11, 2024
fe5fab0
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 11, 2024
946c998
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 11, 2024
5f9da13
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 12, 2024
84e61d1
Add unit tests for fieldNames and LOOKUP JOIN
craigtaverner Dec 12, 2024
26edaad
Merge branch 'fix-lookupjoin-wildcard-fieldcaps' of github.com:craigt…
craigtaverner Dec 12, 2024
9884ac3
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 12, 2024
b198f02
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 12, 2024
623c0d5
Fix failing tests
craigtaverner Dec 12, 2024
32b665e
Merge branch 'fix-lookupjoin-wildcard-fieldcaps' of github.com:craigt…
craigtaverner Dec 12, 2024
b7c647f
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 12, 2024
acae4f1
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 12, 2024
72bed93
Fix failing test and renamed method call
craigtaverner Dec 13, 2024
c18eba0
Merge remote-tracking branch 'origin/main' into fix-lookupjoin-wildca…
craigtaverner Dec 13, 2024
90197a9
Added more csv-spec tests with more KEEPS and STATS before LOOKUP JOIN
craigtaverner Dec 13, 2024
1678b2d
Merge branch 'fix-lookupjoin-wildcard-fieldcaps' of github.com:craigt…
craigtaverner Dec 13, 2024
5a6828a
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 13, 2024
d41b021
Merge remote-tracking branch 'origin/main' into fix-lookupjoin-wildca…
craigtaverner Dec 13, 2024
67bf773
Increment capability number to prevent overlap with other work
craigtaverner Dec 13, 2024
1d11e8e
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 13, 2024
84e6226
Fix compile error after merging main
craigtaverner Dec 13, 2024
64f3523
Merge branch 'fix-lookupjoin-wildcard-fieldcaps' of github.com:craigt…
craigtaverner Dec 13, 2024
a2bdc02
Added unit tests and csv-spec tests for lookup-join on the same index…
craigtaverner Dec 13, 2024
99dbc09
Rename class for clarity of purpose
craigtaverner Dec 13, 2024
134a152
Added tests for wildcard KEEP
craigtaverner Dec 13, 2024
3d05ab4
Reordered expected fields to be more like rest of test class
craigtaverner Dec 13, 2024
a1fdf4e
Added tests using results from one lookup as join key in next lookup
craigtaverner Dec 13, 2024
52bd37e
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 13, 2024
c4589bc
Added RequestIndexFilteringTest on missing LOOKUP JOIN index
craigtaverner Dec 13, 2024
dda8b2e
Block running in mixed clusters
craigtaverner Dec 13, 2024
57ba4ec
Merge remote-tracking branch 'origin/main' into fix-lookupjoin-wildca…
craigtaverner Dec 16, 2024
3b4776e
Added more tests for KEEP before, between and after joins when using ROW
craigtaverner Dec 16, 2024
05408b5
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 16, 2024
cef5753
Fixed capability name after merging main
craigtaverner Dec 16, 2024
4b24022
Fix failing tests after merging in main
craigtaverner Dec 16, 2024
701d589
Merge remote-tracking branch 'origin/main' into fix-lookupjoin-wildca…
craigtaverner Dec 16, 2024
d78b655
Just use one index name
craigtaverner Dec 16, 2024
8e3f9b2
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 16, 2024
4225976
Merge branch 'main' into fix-lookupjoin-wildcard-fieldcaps
craigtaverner Dec 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import java.util.List;

import static org.elasticsearch.xpack.esql.CsvTestUtils.isEnabled;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.JOIN_LOOKUP_V5;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.JOIN_LOOKUP_V6;
import static org.elasticsearch.xpack.esql.qa.rest.EsqlSpecTestCase.Mode.ASYNC;

public class MixedClusterEsqlSpecIT extends EsqlSpecTestCase {
Expand Down Expand Up @@ -96,7 +96,7 @@ protected boolean supportsInferenceTestService() {

@Override
protected boolean supportsIndexModeLookup() throws IOException {
return hasCapabilities(List.of(JOIN_LOOKUP_V5.capabilityName()));
return hasCapabilities(List.of(JOIN_LOOKUP_V6.capabilityName()));
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
import static org.elasticsearch.xpack.esql.EsqlTestUtils.classpathResources;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.INLINESTATS;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.INLINESTATS_V2;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.JOIN_LOOKUP_V5;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.JOIN_LOOKUP_V6;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.JOIN_PLANNING_V1;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.METADATA_FIELDS_REMOTE_TEST;
import static org.elasticsearch.xpack.esql.qa.rest.EsqlSpecTestCase.Mode.SYNC;
Expand Down Expand Up @@ -124,7 +124,7 @@ protected void shouldSkipTest(String testName) throws IOException {
assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(INLINESTATS.capabilityName()));
assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(INLINESTATS_V2.capabilityName()));
assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(JOIN_PLANNING_V1.capabilityName()));
assumeFalse("LOOKUP JOIN not yet supported in CCS", testCase.requiredCapabilities.contains(JOIN_LOOKUP_V5.capabilityName()));
assumeFalse("LOOKUP JOIN not yet supported in CCS", testCase.requiredCapabilities.contains(JOIN_LOOKUP_V6.capabilityName()));
}

private TestFeatureService remoteFeaturesService() throws IOException {
Expand Down Expand Up @@ -283,8 +283,8 @@ protected boolean supportsInferenceTestService() {

@Override
protected boolean supportsIndexModeLookup() throws IOException {
// CCS does not yet support JOIN_LOOKUP_V5 and clusters falsely report they have this capability
// return hasCapabilities(List.of(JOIN_LOOKUP_V5.capabilityName()));
// CCS does not yet support JOIN_LOOKUP_V6 and clusters falsely report they have this capability
// return hasCapabilities(List.of(JOIN_LOOKUP_V6.capabilityName()));
return false;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import org.elasticsearch.test.rest.ESRestTestCase;
import org.elasticsearch.xcontent.XContentType;
import org.elasticsearch.xpack.esql.AssertWarnings;
import org.elasticsearch.xpack.esql.action.EsqlCapabilities;
import org.junit.After;
import org.junit.Assert;

Expand Down Expand Up @@ -219,6 +220,16 @@ public void testIndicesDontExist() throws IOException {
assertEquals(404, e.getResponse().getStatusLine().getStatusCode());
assertThat(e.getMessage(), containsString("index_not_found_exception"));
assertThat(e.getMessage(), containsString("no such index [foo]"));

if (EsqlCapabilities.Cap.JOIN_LOOKUP_V6.isEnabled()) {
e = expectThrows(
ResponseException.class,
() -> runEsql(timestampFilter("gte", "2020-01-01").query("FROM test1 | LOOKUP JOIN foo ON id1"))
);
assertEquals(400, e.getResponse().getStatusLine().getStatusCode());
assertThat(e.getMessage(), containsString("verification_exception"));
assertThat(e.getMessage(), containsString("Unknown index [foo]"));
}
}

private static RestEsqlTestCase.RequestObjectBuilder timestampFilter(String op, String date) throws IOException {
Expand Down
Loading