ESQL: Add CCS tests for FLS and DLS against data streams#118423
Merged
Conversation
nik9000
approved these changes
Dec 11, 2024
Member
nik9000
left a comment
There was a problem hiding this comment.
Seems like a good way to go to me. I would have put it in an x-pack/plugin/esql/qa submodule, but it's just fine here.
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Contributor
Author
|
@nik9000 thanks for the review! I'll merge as is to get more runs in CI, then follow up with more coverage/clean up. |
Contributor
Author
The reason I put it under |
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Dec 12, 2024
) CCS test coverage for elastic#118378
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Dec 12, 2024
) CCS test coverage for elastic#118378
This was referenced Dec 12, 2024
Collaborator
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Dec 12, 2024
) CCS test coverage for elastic#118378
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 12, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 12, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 12, 2024
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
) (elastic#118526) CCS test coverage for elastic#118378
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
) (elastic#118526) CCS test coverage for elastic#118378
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Jan 22, 2025
) (elastic#118524) CCS test coverage for elastic#118378
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CCS test coverage for #118378