Some ILM tidying cleanups, mostly around String formatting #118338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>non-issue
:Data Management/ILM+SLM
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
nielsbauman
approved these changes
Dec 10, 2024
Contributor
nielsbauman
left a comment
nielsbauman
left a comment
There was a problem hiding this comment.
LGTM! I appreciate these kinds of cleanups 😄 Thanks, Joe!
joegallo
added
the
auto-backport
Collaborator
💚 Backport successful
|
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Dec 10, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 10, 2024
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on some code in an ILM action and step, and I ended up seeing some things that were off, so then I figure I'd fix those issues for all ILM actions and steps. I had to stop somewhere, so I stopped here.
Each commit is an independent little unit of work, so IMHO opinion it's best to go through the review a commit at a time (but that's just a suggestion).