[Entitlements] Building scope -> entitlements map during PolicyManager initialization #118070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jdconrad
approved these changes
Dec 11, 2024
Contributor
jdconrad
left a comment
jdconrad
left a comment
There was a problem hiding this comment.
LGTM!
A couple of thoughts:
- Does this affect our ability to add class/method level scoping should that ever become a requirement?
- Do we still need
PolicyandScopeor should we just directly parse into the maps as they're being built here?
Contributor
Author
I don't think so, we will need to update the map key so instead of being "just" a module name is module name/package/class. Or we can have a 2 level map (map of maps). Anyway, it will stay an internal detail.
I kind of like the current structure; Policy and Scope are parser-level concepts, how we organize them efficiently should stay internal to PolicyManager (so we are free to change them, see point above). |
Collaborator
💚 Backport successful
|
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Dec 12, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 12, 2024
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #117239
Instead of scanning policies for modules names, build a scope -> entitlements map during construction.