ESQL: Simplify CombineProjections#117882
Merged
alex-spies merged 5 commits intoelastic:mainfrom Dec 3, 2024
Merged
Conversation
combineUpperGroupingsAndLowerProjections can be made a bit simpler.
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
added
the
auto-backport
alex-spies
added a commit
to alex-spies/elasticsearch
that referenced
this pull request
Dec 3, 2024
Make combineUpperGroupingsAndLowerProjections a bit simpler. Also slightly improve a test and add comments to provide more context.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#114317 needed to amend the
CombineProjectionslogical optimizer rule to account for theCATEGORIZEfunction.I believe this can be a tiny bit simplified, more specifically the method combineUpperGroupingsAndLowerProjections - c.f. #114317 (comment).