Improve message about insecure S3 settings #116915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies that insecure settings are stored in plaintext and must not be used. Also removes the mention of the (wrong) system property from the error message if insecure settings are not permitted.
DaveCTurner
added
>enhancement
:Distributed Coordination/Snapshot/Restore
henningandersen
approved these changes
Nov 18, 2024
server/src/main/java/org/elasticsearch/common/settings/SecureSetting.java
Outdated
Show resolved
Hide resolved
…etting.java Co-authored-by: Henning Andersen <[email protected]>
DaveCTurner
added
the
auto-backport
elasticsearchmachine
added
the
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Collaborator
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
Collaborator
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 18, 2024
Clarifies that insecure settings are stored in plaintext and must not be used. Also removes the mention of the (wrong) system property from the error message if insecure settings are not permitted.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 18, 2024
Clarifies that insecure settings are stored in plaintext and must not be used. Also removes the mention of the (wrong) system property from the error message if insecure settings are not permitted. Backport of elastic#116915 to `8.x`
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 18, 2024
Clarifies that insecure settings are stored in plaintext and must not be used. Also removes the mention of the (wrong) system property from the error message if insecure settings are not permitted. Backport of elastic#116915 to `8.16`
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 18, 2024
Clarifies that insecure settings are stored in plaintext and must not be used. Also removes the mention of the (wrong) system property from the error message if insecure settings are not permitted. Backport of elastic#116915 to `7.17`
Contributor
Author
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2024
Clarifies that insecure settings are stored in plaintext and must not be used. Also removes the mention of the (wrong) system property from the error message if insecure settings are not permitted. Backport of #116915 to `8.x`
DaveCTurner
added a commit
that referenced
this pull request
Nov 18, 2024
Clarifies that insecure settings are stored in plaintext and must not be used. Also removes the mention of the (wrong) system property from the error message if insecure settings are not permitted. Backport of #116915 to `8.16`
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2024
* Improve message about insecure S3 settings Clarifies that insecure settings are stored in plaintext and must not be used. Also removes the mention of the (wrong) system property from the error message if insecure settings are not permitted. Backport of #116915 to `7.17` * CI poke
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Clarifies that insecure settings are stored in plaintext and must not be used. Also removes the mention of the (wrong) system property from the error message if insecure settings are not permitted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies that insecure settings are stored in plaintext and must not be
used. Also removes the mention of the (wrong) system property from the
error message if insecure settings are not permitted.