Fast refresh indices to use search shards#116658
Merged
kingherc merged 8 commits intoelastic:mainfrom Nov 19, 2024
Merged
Conversation
The changes of PR elastic#115019 were reverted because it induced ES-8275. Now that the ticket is done, this PR re-introduces the reverted changes. Fast refresh indices should now behave like non fast refresh indices in how they execute (m)gets and searches. I.e., they should use the search shards. For BWC, we define a new transport version. We expect search shards to be upgraded first, before promotable shards. Until the cluster is fully upgraded, the promotable shards (whether upgraded or not) will still receive and execute gets/searches locally. Relates ES-9573
kingherc
added
>non-issue
:Distributed/Engine
elasticsearchmachine
added
the
serverless-linked
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
…dapt-fast-refresh
…dapt-fast-refresh
…dapt-fast-refresh
…dapt-fast-refresh
Contributor
henningandersen
left a comment
henningandersen
left a comment
There was a problem hiding this comment.
Besides the new transport version is this then a clean reintroduction of the original change or did you have to adapt it?
kingherc
commented
Nov 14, 2024
Contributor
Author
kingherc
left a comment
kingherc
left a comment
There was a problem hiding this comment.
Besides the new transport version is this then a clean reintroduction of the original change or did you have to adapt it?
@henningandersen clean re-introduction. Only the part around BitsetFilterCache.java is different than the original PR, because we did not revert the changes in that one (meaning, we left it fixed rather than reverting it to the wrong older code). So now it's a more straightforward change to adapt fast refresh there.
…dapt-fast-refresh
…dapt-fast-refresh
kingherc
added a commit
to kingherc/elasticsearch
that referenced
this pull request
Nov 20, 2024
Backport of PR elastic#116658. Changes of this PR are ineffective for stateful, and backport is not used in serverless. This is mostly to adopt the new transport version in stateful to keep them consecutive. Relates ES-9573
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 20, 2024
Backport of PR #116658. Changes of this PR are ineffective for stateful, and backport is not used in serverless. This is mostly to adopt the new transport version in stateful to keep them consecutive. Relates ES-9573
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 20, 2024
The changes of PR elastic#115019 were reverted because it induced ES-8275. Now that the ticket is done, this PR re-introduces the reverted changes. Fast refresh indices should now behave like non fast refresh indices in how they execute (m)gets and searches. I.e., they should use the search shards. For BWC, we define a new transport version. We expect search shards to be upgraded first, before promotable shards. Until the cluster is fully upgraded, the promotable shards (whether upgraded or not) will still receive and execute gets/searches locally. Relates ES-9573
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
The changes of PR elastic#115019 were reverted because it induced ES-8275. Now that the ticket is done, this PR re-introduces the reverted changes. Fast refresh indices should now behave like non fast refresh indices in how they execute (m)gets and searches. I.e., they should use the search shards. For BWC, we define a new transport version. We expect search shards to be upgraded first, before promotable shards. Until the cluster is fully upgraded, the promotable shards (whether upgraded or not) will still receive and execute gets/searches locally. Relates ES-9573
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes of PR #113478 were reverted because it induced ES-8275. Now that the ticket is done, this PR re-introduces the reverted changes.
Fast refresh indices should now behave like non fast refresh indices in how they execute (m)gets and searches. I.e., they should use the search shards.
For BWC, we define a new transport version. We expect search shards to be upgraded first, before promotable shards. Until the cluster is fully upgraded, the promotable shards (whether upgraded or not) will still receive and execute gets/searches locally.
Relates ES-9573