Use settings from LogsdbIndexModeSettingsProvider in SyntheticSourceIndexSettingsProvider #115437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndexSettingsProvider
kkrik-es
added
>non-issue
auto-backport
kkrik-es
changed the title
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Oct 24, 2024
| ); | ||
| private static final String LOGS_PATTERN = "logs-*-*"; | ||
| private volatile boolean isLogsdbEnabled; | ||
| private boolean isLogsdbEnabled; |
Member
There was a problem hiding this comment.
I think this need field needs to stay volatile? It can be updated via cluster settings update at runtime.
Contributor
Author
There was a problem hiding this comment.
Yes sorry, unintended.
Collaborator
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
kkrik-es
added a commit
to kkrik-es/elasticsearch
that referenced
this pull request
Oct 24, 2024
…ndexSettingsProvider (elastic#115437) * Use settings from LogsdbIndexModeSettingsProvider in SyntheticSourceIndexSettingsProvider * update (cherry picked from commit 6f7bd55)
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Oct 24, 2024
…ndexSettingsProvider (elastic#115437) * Use settings from LogsdbIndexModeSettingsProvider in SyntheticSourceIndexSettingsProvider * update
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
…ndexSettingsProvider (elastic#115437) * Use settings from LogsdbIndexModeSettingsProvider in SyntheticSourceIndexSettingsProvider * update
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
…ndexSettingsProvider (elastic#115437) * Use settings from LogsdbIndexModeSettingsProvider in SyntheticSourceIndexSettingsProvider * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The synthetic source provider needs to use the injected logsdb mode setting to detect that synthetic source is to be used.
This is an alternative to #115397, more localized but requires creating another copy of all template and request settings.