Make prompt placeholders consistent with existing placeholders #11514
Conversation
There was a problem hiding this comment.
do we really want to ignore missing for prompt?
There was a problem hiding this comment.
Yes we do.
This is still messy for 1.6. At the time this is called, we haven't prompted the user so the PlaceholderResolver isn't able to resolve prompts so they'll always be missing and we need to ignore them. The shouldRemoveMissingPlaceholder method is added so that we don't set the value to an empty string; instead we leave the ${prompt.text} value, which is resolved later on by the InternalSettingsPreparer. We also can't add the prompting here without adding another Map since a placeholder could be in a system property and we add those to the settings multiple times in the InternalSettingsPreparer.
When we implement #11455, we will need to fix this...
|
LGTM |
In elastic#10918, we introduced the prompt placeholders. These were had a different format than our existing placeholders. This changes the prompt placeholders to follow the format of the existing placeholders. Relates to elastic#11455
clintongormley
changed the title
clintongormley
added
>enhancement
:Core/Infra/Settings
3 participants
In #10918, we introduced the prompt placeholders. These had a different format
than our existing placeholders. This changes the prompt placeholders to follow the
format of the existing placeholders.
Relates to #11455
Note: This PR is targeted to 1.x to make porting to 1.x and 1.6 easier. Will manually port to master.