Skip to content

(Doc+) Cross-link max shards#114670

Merged
stefnestor merged 2 commits intomainfrom
stefnestor-patch-2
Oct 16, 2024
Merged

(Doc+) Cross-link max shards#114670
stefnestor merged 2 commits intomainfrom
stefnestor-patch-2

Conversation

@stefnestor
Copy link
Copy Markdown
Member

👋 It appears we have two docs of similar content about max open shards. This one contains the error users search (so is what we linked the error to in #110993) but the other I believe is a placeholder doc for the health api code. Should maybe consolidate some day but in the mean time at least cross-link for discoverability.

👋 It appears we have two docs of similar content about max open shards. This one contains the error users search (so is what we linked the error to in #110993) but the other I believe is a placeholder doc for the health api code. Should maybe consolidate some day but in the mean time at least cross-link.
@stefnestor stefnestor added >enhancement >docs General docs changes Team:Docs Meta label for docs team labels Oct 11, 2024
@stefnestor stefnestor requested a review from a team October 11, 2024 23:12
@github-actions
Copy link
Copy Markdown
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added v9.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 11, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

@stefnestor please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

Copy link
Copy Markdown
Member

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one syntax fix

Comment thread docs/reference/how-to/size-your-shards.asciidoc Outdated
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
@leemthompo
Copy link
Copy Markdown
Member

@stefnestor also do you want to backport these to 8.something?

@leemthompo leemthompo removed the external-contributor Pull request authored by a developer outside the Elasticsearch team label Oct 16, 2024
@stefnestor stefnestor added auto-backport Automatically create backport pull requests when merged v8.16.0 labels Oct 16, 2024
@stefnestor stefnestor merged commit bd754f7 into main Oct 16, 2024
@stefnestor stefnestor deleted the stefnestor-patch-2 branch October 16, 2024 15:30
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 114670

georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
* (Doc+) Cross-link max shards

👋 It appears we have two docs of similar content about max open shards. This one contains the error users search (so is what we linked the error to in elastic#110993) but the other I believe is a placeholder doc for the health api code. Should maybe consolidate some day but in the mean time at least cross-link.

---------

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
* (Doc+) Cross-link max shards

👋 It appears we have two docs of similar content about max open shards. This one contains the error users search (so is what we linked the error to in elastic#110993) but the other I believe is a placeholder doc for the health api code. Should maybe consolidate some day but in the mean time at least cross-link.

---------

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending >docs General docs changes >enhancement Team:Docs Meta label for docs team v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants