Skip to content

[8.x] Ensure green step in synonyms rule yaml test (#114400)#114426

Closed
kingherc wants to merge 1 commit intoelastic:8.xfrom
kingherc:backport/8.x/pr-114400
Closed

[8.x] Ensure green step in synonyms rule yaml test (#114400)#114426
kingherc wants to merge 1 commit intoelastic:8.xfrom
kingherc:backport/8.x/pr-114400

Conversation

@kingherc
Copy link
Contributor

@kingherc kingherc commented Oct 9, 2024

Backports the following commits to 8.x:

@kingherc kingherc added :Search Relevance/Analysis How text is split into tokens >test-failure Triaged test failures from CI auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport needs:risk Requires assignment of a risk label (low, medium, blocker) serverless-linked Added by automation, don't add manually Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Oct 9, 2024
@kingherc
Copy link
Contributor Author

kingherc commented Oct 9, 2024

@benwtrent I saw you had put the backport label on my PR. Might you know if we truly need this PR? I'd like to see if we should put effort in fixing the CI failures here. My belief is not since we're using main in serverless. cc @carlosdelest

@kingherc
Copy link
Contributor Author

Since I see @carlosdelest 's thumbs up, I assume you mean it's not needed so I'm closing this. Feel free to tell me whether we should re-open it and investigate it.

@kingherc kingherc closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport needs:risk Requires assignment of a risk label (low, medium, blocker) :Search Relevance/Analysis How text is split into tokens serverless-linked Added by automation, don't add manually Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test-failure Triaged test failures from CI v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants