Fix bitset filter cache loading in Stateless#114191
Merged
kingherc merged 3 commits intoelastic:mainfrom Oct 11, 2024
Merged
Conversation
As recognized in PR elastic#113478 reviewing, the bitset filter cache was wrongly eagerly loaded only for fast refresh indices on index nodes. However, it should be eagerly loaded for any index that can be searched. This PR fixes this.
kingherc
added
>non-issue
:Search/Search
kingherc
requested review from
JVerwolf,
henningandersen and
original-brownbear
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
henningandersen
approved these changes
Oct 7, 2024
Contributor
henningandersen
left a comment
henningandersen
left a comment
There was a problem hiding this comment.
LGTM (but we should have a search team review here).
Ideally we'd merge #113478 first, then this PR simplifies even more.
…itset-filter-cache
…itset-filter-cache
Contributor
Author
|
Gentle reminder for search team to review this. cc @original-brownbear , @JVerwolf |
Contributor
Author
|
Gentle reminder for review by @elastic/es-search-foundations , @original-brownbear , @JVerwolf |
JVerwolf
approved these changes
Oct 10, 2024
kingherc
added a commit
to kingherc/elasticsearch
that referenced
this pull request
Oct 11, 2024
As recognized in PR elastic#113478 reviewing, the bitset filter cache was wrongly eagerly loaded only for fast refresh indices on index nodes. However, it should be eagerly loaded for any index that can be searched. This PR fixes this.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 11, 2024
As recognized in PR #113478 reviewing, the bitset filter cache was wrongly eagerly loaded only for fast refresh indices on index nodes. However, it should be eagerly loaded for any index that can be searched. This PR fixes this.
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Oct 13, 2024
As recognized in PR elastic#113478 reviewing, the bitset filter cache was wrongly eagerly loaded only for fast refresh indices on index nodes. However, it should be eagerly loaded for any index that can be searched. This PR fixes this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As recognized in this comment discussion, the bitset filter cache was wrongly eagerly loaded only for fast refresh indices on index nodes in PR #105791 . However, it should be eagerly loaded for any index that can be searched. This PR fixes this. After #113478 , searches can happen only on search nodes (irrespective of whether an index is fast refresh or not), so doing that in this PR.