Skip to content

Fix synthetic source field names for multi-fields#112850

Merged
kkrik-es merged 6 commits intoelastic:mainfrom
kkrik-es:synthetic-source/fix-field-name
Sep 13, 2024
Merged

Fix synthetic source field names for multi-fields#112850
kkrik-es merged 6 commits intoelastic:mainfrom
kkrik-es:synthetic-source/fix-field-name

Conversation

@kkrik-es
Copy link
Contributor

@kkrik-es kkrik-es commented Sep 13, 2024

Forked off #112706, so that fixes can be backported to 8.15.2. Test coverage will be added in the parent PR.

For mullti-fields, the synthetic source field name should reflect the name of the parent field, as subfields may contain injected suffices.

@elasticsearchmachine
Copy link
Collaborator

Hi @kkrik-es, I've created a changelog YAML for you.

@kkrik-es kkrik-es marked this pull request as ready for review September 13, 2024 11:53
@kkrik-es kkrik-es requested a review from lkts September 13, 2024 11:53
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@kkrik-es
Copy link
Contributor Author

Since the parent PR is approved, I'm taking the liberty to submit this without explicit stamps.

@kkrik-es kkrik-es merged commit 86a88d7 into elastic:main Sep 13, 2024
kkrik-es added a commit to kkrik-es/elasticsearch that referenced this pull request Sep 13, 2024
* Fix synthetic source field names for multi-fields

* enable logsdb in randomized tests

* Revert "enable logsdb in randomized tests"

This reverts commit 2e2c22e.

* Update docs/changelog/112850.yaml

* fix
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x
8.15 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 112850

kkrik-es added a commit to kkrik-es/elasticsearch that referenced this pull request Sep 13, 2024
* Fix synthetic source field names for multi-fields

* enable logsdb in randomized tests

* Revert "enable logsdb in randomized tests"

This reverts commit 2e2c22e.

* Update docs/changelog/112850.yaml

* fix

(cherry picked from commit 86a88d7)
Copy link
Contributor

@lkts lkts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

elasticsearchmachine pushed a commit that referenced this pull request Sep 13, 2024
* Fix synthetic source field names for multi-fields

* enable logsdb in randomized tests

* Revert "enable logsdb in randomized tests"

This reverts commit 2e2c22e.

* Update docs/changelog/112850.yaml

* fix

(cherry picked from commit 86a88d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants