Teach XContentGenerator#copyCurrentEvent to handle BigInteger and BigDecimal#111936
Closed
lkts wants to merge 3 commits intoelastic:mainfrom
Closed
Teach XContentGenerator#copyCurrentEvent to handle BigInteger and BigDecimal#111936lkts wants to merge 3 commits intoelastic:mainfrom
lkts wants to merge 3 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @lkts, I've created a changelog YAML for you. |
lkts
commented
Aug 15, 2024
| case VALUE_NUMBER: | ||
| switch (parser.numberType()) { | ||
| case INT -> writeNumber(parser.intValue()); | ||
| case BIG_INTEGER -> writeNumber((BigInteger) parser.numberValue()); |
Contributor
Author
There was a problem hiding this comment.
I don't see a way to do this without casting.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Member
Contributor
Author
|
thanks @rjernst |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This logic was simply missing from the implementation. It's a pretty tricky case since it only reproduces with wrapped parsers but works fine when directly using
JsonXContentParser.Closes #111812.