Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
fb915d3
Moved test case generators to AbstractFunctionTestCase and fixed for …
ivancea Jul 31, 2024
fe46b90
Max and Min tests, and fixes for testint folding and nulls
ivancea Jul 31, 2024
743e010
Updated AVG and WEIGHTED_AVG tests
ivancea Jul 31, 2024
cedb0f3
Deprecated old DefaultChekcs method
ivancea Jul 31, 2024
efb188c
Remove repeated tests
ivancea Jul 31, 2024
87d90c3
Fixed tests after fix in MIN/MAX type checks
ivancea Jul 31, 2024
e49f5ce
Merge branch 'main' into aggregation-test-cases-types-nulls
ivancea Aug 1, 2024
59d9aca
Updated after merge with validFunctionParameters change
ivancea Aug 1, 2024
7e5521b
Fixed VerifierTests
ivancea Aug 1, 2024
8447df0
Added new available types to Max and Min, and function tests
ivancea Aug 1, 2024
5f136cf
Merge branch 'main' into max-min-aggs-bytesref
ivancea Aug 1, 2024
e446268
Added BytesRef state implementation
ivancea Aug 1, 2024
f985f6b
Minor fixes and added capability
ivancea Aug 1, 2024
c4ada6f
CSV version tests
ivancea Aug 1, 2024
2ce4be6
CSV tests for max and min with strings
ivancea Aug 2, 2024
1868f5f
Update docs/changelog/111544.yaml
ivancea Aug 2, 2024
91762a6
Removed unused import
ivancea Aug 2, 2024
81647b5
Merge branch 'main' into max-min-aggs-bytesref
elasticmachine Aug 2, 2024
abd30fd
Fixed tests using min and max
ivancea Aug 2, 2024
1bae79b
Merge branch 'main' into max-min-aggs-bytesref
ivancea Aug 12, 2024
1f96da2
Use BreakingBytesRefBuilder in array state
ivancea Aug 12, 2024
d205001
Added copyBytes method
ivancea Aug 12, 2024
81a6088
Added comments about BytesRef ordering to javadocs
ivancea Aug 12, 2024
55fd207
Merge branch 'main' into max-min-aggs-bytesref
ivancea Aug 20, 2024
59ebfed
Removed seen array from BytesRefArrayState and add Max/Min aggregator…
ivancea Aug 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/111544.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 111544
summary: "ESQL: Strings support for MAX and MIN aggregations"
area: ES|QL
type: feature
issues: []
36 changes: 36 additions & 0 deletions docs/reference/esql/functions/kibana/definition/max.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions docs/reference/esql/functions/kibana/definition/min.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions docs/reference/esql/functions/types/max.asciidoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions docs/reference/esql/functions/types/min.asciidoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public AggregatorImplementer(Elements elements, TypeElement declarationType, Int
this.createParameters = init.getParameters()
.stream()
.map(Parameter::from)
.filter(f -> false == f.type().equals(BIG_ARRAYS))
.filter(f -> false == f.type().equals(BIG_ARRAYS) && false == f.type().equals(DRIVER_CONTEXT))
.toList();

this.implementation = ClassName.get(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ public class Types {
static final TypeName BLOCK_ARRAY = ArrayTypeName.of(BLOCK);
static final ClassName VECTOR = ClassName.get(DATA_PACKAGE, "Vector");

static final ClassName CIRCUIT_BREAKER = ClassName.get("org.elasticsearch.common.breaker", "CircuitBreaker");
static final ClassName BIG_ARRAYS = ClassName.get("org.elasticsearch.common.util", "BigArrays");

static final ClassName BOOLEAN_BLOCK = ClassName.get(DATA_PACKAGE, "BooleanBlock");
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading