ESQL: Add Values aggregation tests, fix ConstantBytesRefVector memory handling #111367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/MultiRowTestCaseSupplier.java
Contributor
|
Documentation preview: |
elasticsearchmachine
added
needs:triage
ivancea
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Pinging @elastic/kibana-esql (ES|QL-ui) |
Collaborator
|
Hi @ivancea, I've created a changelog YAML for you. |
ivancea
changed the title
nik9000
reviewed
Jul 26, 2024
| Constant$Type$Vector($type$ value, int positionCount, BlockFactory blockFactory) { | ||
| super(positionCount, blockFactory); | ||
| $if(BytesRef)$ | ||
| this.value = BytesRef.deepCopyOf(value); |
Member
There was a problem hiding this comment.
I wonder if we're better off copying on the caller. I imagine there are lots of folks who already deep copy.
ivancea
commented
Jul 26, 2024
| }); | ||
| } | ||
|
|
||
| private static <T, C extends T> Matcher<Object> valuesInAnyOrder(Collection<T> data) { |
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
This PR was merged with #111409 by error, as it was a dependent branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.