Skip to content

[ML] Fix failing test DetectionRulesTests.testEqualsAndHashcode #111351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valeriy42 merged 3 commits into from
Jul 29, 2024
Merged

[ML] Fix failing test DetectionRulesTests.testEqualsAndHashcode #111351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c74b6d2
Fix failing test condition
valeriy42 Jul 26, 2024
214842d
remove fixed test from the list
valeriy42 Jul 26, 2024
8f18072
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
valeriy42 Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,6 @@ tests:
- class: org.elasticsearch.upgrades.LogsIndexModeFullClusterRestartIT
method: testLogsIndexing {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/111306
- class: org.elasticsearch.xpack.core.ml.job.config.DetectionRuleTests
method: testEqualsAndHashcode
issue: https://github.com/elastic/elasticsearch/issues/111308
- class: org.elasticsearch.xpack.ml.integration.DatafeedJobsRestIT
issue: https://github.com/elastic/elasticsearch/issues/111319
- class: org.elasticsearch.xpack.esql.analysis.VerifierTests
Expand Down
2 changes: 2 additions & 0 deletions ...gin/core/src/test/java/org/elasticsearch/xpack/core/ml/job/config/DetectionRuleTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ protected DetectionRule mutateInstance(DetectionRule instance) {

if (actions.contains(RuleAction.FORCE_TIME_SHIFT) && params.getForceTimeShift() == null) {
params = new RuleParams(new RuleParamsForForceTimeShift(randomLong()));
} else if (actions.contains(RuleAction.FORCE_TIME_SHIFT) == false && params.getForceTimeShift() != null) {
params = new RuleParams();
}

return new DetectionRule.Builder(conditions).setActions(actions).setScope(scope).setParams(params).build();
Expand Down