Updating error message for missing shards in open_point_in_time action#111320
Merged
pmpailis merged 6 commits intoelastic:mainfrom Jul 29, 2024
Merged
Conversation
pmpailis
added
>non-issue
:Search Foundations/Search
elasticsearchmachine
added
v8.16.0
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
dnhatn
approved these changes
Jul 26, 2024
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
I left an optional comment, but LGTM.
| ) { | ||
| @Override | ||
| protected String missingShardsErrorMessage(StringBuilder missingShards) { | ||
| return "Search rejected due to missing shards. [open_point_in_time] action requires all shards to be available."; |
Member
There was a problem hiding this comment.
Maybe remove the prefix "Search rejected due to missing shards." and add "missing shards[" + missingShards +"]" at the end of the message?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we update the exception message for the
open_point_in_timeaction to avoid suggesting the use ofallow_partial_search_resultsas it is not currently supported, and explicitly set to false for PIT.Relates to #103165 and this PR comment.