ESQL: Correctly compute Rename's output#110968
Merged
alex-spies merged 6 commits intoelastic:mainfrom Jul 17, 2024
Merged
Conversation
alex-spies
added
>test-failure
elasticsearchmachine
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
luigidellaquila
approved these changes
Jul 17, 2024
Member
luigidellaquila
left a comment
luigidellaquila
left a comment
There was a problem hiding this comment.
LGTM, good that #110488 exposed the problem
This reverts commit b1d4333.
Contributor
Author
|
Actually, there's other physical plans that eagerly compute their children's outputs. Had another failure for I'll update the PR. |
alex-spies
changed the title
alex-spies
commented
Jul 17, 2024
Comment on lines
-9
to
-10
| import org.apache.logging.log4j.LogManager; | ||
| import org.apache.logging.log4j.Logger; |
Contributor
Author
There was a problem hiding this comment.
These shouldn't have been using log4j directly.
luigidellaquila
approved these changes
Jul 17, 2024
Member
luigidellaquila
left a comment
luigidellaquila
left a comment
There was a problem hiding this comment.
If the CI is happy, I'm happy as well
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
alex-spies
added a commit
to alex-spies/elasticsearch
that referenced
this pull request
Jul 17, 2024
Calling Rename.output() previously returned wrong results. Since elastic#110488, instead it throws an IllegalStateException. That leads to test failures in the EsqlNodeSubclassTests because e.g. MvExpandExec and FieldExtractExec eagerly calls .output() on its child when it's being constructed, and the child can be a fragment containing a Rename. (cherry picked from commit 7df1b06) # Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/Rename.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 17, 2024
Calling Rename.output() previously returned wrong results. Since #110488, instead it throws an IllegalStateException. That leads to test failures in the EsqlNodeSubclassTests because e.g. MvExpandExec and FieldExtractExec eagerly calls .output() on its child when it's being constructed, and the child can be a fragment containing a Rename. (cherry picked from commit 7df1b06) # Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/Rename.java
This was referenced Jul 17, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 18, 2024
The test failure was already fixed in #110968.
ioanatia
pushed a commit
to ioanatia/elasticsearch
that referenced
this pull request
Jul 22, 2024
Calling Rename.output() previously returned wrong results. Since elastic#110488, instead it throws an IllegalStateException. That leads to test failures in the EsqlNodeSubclassTests because e.g. MvExpandExec and FieldExtractExec eagerly calls .output() on its child when it's being constructed, and the child can be a fragment containing a Rename.
ioanatia
pushed a commit
to ioanatia/elasticsearch
that referenced
this pull request
Jul 22, 2024
The test failure was already fixed in elastic#110968.
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jul 23, 2024
Calling Rename.output() previously returned wrong results. Since elastic#110488, instead it throws an IllegalStateException. That leads to test failures in the EsqlNodeSubclassTests because e.g. MvExpandExec and FieldExtractExec eagerly calls .output() on its child when it's being constructed, and the child can be a fragment containing a Rename.
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jul 23, 2024
The test failure was already fixed in elastic#110968.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #110967
Calling
Rename.output()previously returned wrong results.Since #110488, instead it throws an
IllegalStateException. That leads to test failures in theEsqlNodeSubclassTestsbecause e.g.MvExpandExecandFieldExtractExeceagerly calls.output()on its child when it's being constructed, and the child can be a fragment containing aRename.