Fix FileSettingsUpgradeIT to not create irrelevant clusters at all#110963
Merged
Conversation
thecoop
added
>test
elasticsearchmachine
added
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
added
v8.15.0
auto-backport
ldematte
approved these changes
Jul 17, 2024
Contributor
ldematte
left a comment
ldematte
left a comment
There was a problem hiding this comment.
LGTM
(and TIL about TestRule chain!)
thecoop
added
auto-backport-and-merge
and removed
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Member
Author
|
Doesn't exist in 8.15 |
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jul 17, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 12, 2024
Fixes: #118311 #118310 #118309 Same issue that was fixed in: #110963 `@BeforeClass` is executed after the test rules. This means it creates the clusters for all the invalid versions, which sometimes doesnt work. Change it to a rule which definitely evaluates before the clusters are created. This will also speed up this test in CI.
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
…18455) Fixes: elastic#118311 elastic#118310 elastic#118309 Same issue that was fixed in: elastic#110963 `@BeforeClass` is executed after the test rules. This means it creates the clusters for all the invalid versions, which sometimes doesnt work. Change it to a rule which definitely evaluates before the clusters are created. This will also speed up this test in CI.
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
…18455) Fixes: elastic#118311 elastic#118310 elastic#118309 Same issue that was fixed in: elastic#110963 `@BeforeClass` is executed after the test rules. This means it creates the clusters for all the invalid versions, which sometimes doesnt work. Change it to a rule which definitely evaluates before the clusters are created. This will also speed up this test in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@BeforeClass is executed after the test rules. This means it creates the clusters for all the invalid versions, which sometimes doesnt work.
Change it to a rule which definitely evaluates before the clusters are created. This will also speed up this test in CI
Fixes #110884