Move Retriever Handling to Rewrite Phase#110641
Merged
jimczi merged 3 commits intoelastic:mainfrom Jul 10, 2024
Merged
Conversation
This change moves the handling of the retriever to the rewrite phase. It also adds validation of the search source builder after extracting the retriever into the source builder. Relates elastic#110482
jimczi
added
>non-issue
:Search/Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
mayya-sharipova
approved these changes
Jul 9, 2024
pmpailis
reviewed
Jul 10, 2024
pmpailis
approved these changes
Jul 10, 2024
tvernum
pushed a commit
that referenced
this pull request
Feb 25, 2025
This change moves the handling of the retriever to the rewrite phase. It also adds validation of the search source builder after extracting the retriever into the source builder. Relates #110482
tvernum
pushed a commit
that referenced
this pull request
Feb 25, 2025
This change moves the handling of the retriever to the rewrite phase. It also adds validation of the search source builder after extracting the retriever into the source builder. Relates #110482
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves the handling of the retriever to the rewrite phase.
It also adds validation of the search source builder after extracting the retriever into the source builder.
Relates #110482