[ML] Don't translate already chunked results#110592
Merged
davidkyle merged 1 commit intoelastic:mainfrom Jul 8, 2024
Merged
Conversation
davidkyle
commented
Jul 8, 2024
| } | ||
| } | ||
|
|
||
| private static List<ChunkedInferenceServiceResults> translateToChunkedResults( |
elasticsearchmachine
added
the
needs:triage
markjhoy
approved these changes
Jul 8, 2024
Contributor
markjhoy
left a comment
markjhoy
left a comment
There was a problem hiding this comment.
Ah - this looks good... great catch. 🤦 - more than 1 listener things start to get complicated... 😅
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
elasticsearchmachine
removed
the
needs:triage
Collaborator
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
Contributor
|
(for backtracing, referencing the original PR this fixes: #110248) |
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Jul 9, 2024
…#110592) Fixes error using the Amazon Bedrock service with a large input that was chunked.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 9, 2024
#110624) Fixes error using the Amazon Bedrock service with a large input that was chunked.
tvernum
pushed a commit
that referenced
this pull request
Feb 25, 2025
Fixes error using the Amazon Bedrock service with a large input that was chunked.
tvernum
pushed a commit
that referenced
this pull request
Feb 25, 2025
Fixes error using the Amazon Bedrock service with a large input that was chunked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An error was reported using the Amazon Bedrock service with a large input that was chunked.
The problem was an unnecessary call of
translateToChunkedResultsas theEmbeddingRequestChunkerreturns the right thing.Non issue as it fixes a bug in code merged one working day ago.