(Doc+) Error "number of documents in the index can't exceed"#110449
(Doc+) Error "number of documents in the index can't exceed"#110449leemthompo merged 9 commits intomainfrom
Conversation
👋 howdy, team! This adds resolution outline for error ... which induces ongoing, lowkey support ``` Number of documents in the index can't exceed [2147483519] ```
stefnestor
added
>enhancement
>docs
|
Documentation preview: |
This comment was marked as outdated.
This comment was marked as outdated.
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
external-contributor
|
Thanks, @idegtiarenko ! I've updated error wording to match your PR #110481 while leaving a |
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
I'm hesitant to include this section in size-your-shards.asciidoc since it's not really sizing guidance. I worry that users will see this limit as a target, when in fact the recommended sizing is described further up as aiming for ≤200M docs. I think it's good information to include in the manual for sure, but I'd prefer it to be somewhere in the troubleshooting area of the docs rather than here.
I'd also like to make it so that the error message (see #110481) includes a link to the docs we're adding here.
@DaveCTurner, my interpretation of Troubleshoot shard-related errors at the bottom of the shard sizing page is for messages/errors when you fall out of best practices. However as always, I don't presume to know where your team would like the content as long as it can searchably exist in official docs 🙏 |
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
TIL there's a troubleshooting section at the bottom of the size-your-shards page. Ok, this seems to me like a good spot to write these words.
leemthompo
left a comment
leemthompo
left a comment
There was a problem hiding this comment.
A little editorial review for clarity here, I think mainly we can be a bit more concise here :)
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
I suspect the most helpful thing we can do to make these docs more discoverable is to include a link to them from the exception message. @stefnestor are you comfortable including that change here or would you rather we did that in a follow-up? See e.g. #110681 as a model example of this kind of thing.
@DaveCTurner I applaud linking the error to the docs, but the linked PR does not look like a trivial change (at least to me who has only briefly coded Java & is not familiar with the ES code base), so I would prefer we handle it after separately. |
Sure, no probs, I'll look after that once this is merged. |
…#110449) * (Doc+) Error "number of documents in the index can't exceed" 👋 howdy, team! This adds resolution outline for error ... which induces ongoing, lowkey support ``` Number of documents in the index can't exceed [2147483519] ``` * feedback * feedback Co-authored-by: David Turner <david.turner@elastic.co> * feedback Co-authored-by: David Turner <david.turner@elastic.co> Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com> * feedback * feedback * Test change to address docs check failure * Revert test change * Test docs check --------- Co-authored-by: David Turner <david.turner@elastic.co> Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
💚 Backport successful
|
Follow-up to elastic#110449
#110910) * (Doc+) Error "number of documents in the index can't exceed" 👋 howdy, team! This adds resolution outline for error ... which induces ongoing, lowkey support ``` Number of documents in the index can't exceed [2147483519] ``` * feedback * feedback * feedback * feedback * feedback * Test change to address docs check failure * Revert test change * Test docs check --------- Co-authored-by: David Turner <david.turner@elastic.co> Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
5 participants
👋 howdy, team! This adds resolution outline for error under Troubleshooting shard-related errors ... which induces ongoing, lowkey support
Kindly correct resolution steps as needed 🙂 .