Fix sql JdbcDocCsvSpecIT test {docs.testFilterToday} failing#109274
Merged
ChrisHegarty merged 3 commits intoelastic:mainfrom Jun 3, 2024
Merged
Fix sql JdbcDocCsvSpecIT test {docs.testFilterToday} failing#109274ChrisHegarty merged 3 commits intoelastic:mainfrom
ChrisHegarty merged 3 commits intoelastic:mainfrom
Conversation
ChrisHegarty
added
>test
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
nik9000
approved these changes
Jun 2, 2024
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
Ouch. Fine for now.
We probably should hard code "now" in the tests for make this not so much a thing.
ChrisHegarty
added a commit
that referenced
this pull request
Jun 3, 2024
This commit fixes an SQL test that hardcodes expected results based on today's date. The docs.testFilterToday test needs to be updated since June 2 2024, because Anneke's hire-date of 1989-06-02 (35 years ago as of time of writing) affects the expected output.
ChrisHegarty
added a commit
that referenced
this pull request
Jun 4, 2024
This commit fixes an SQL test that hardcodes expected results based on today's date. The docs.testFilterToday test needs to be updated since June 2 2024, because Anneke's hire-date of 1989-06-02 (35 years ago as of time of writing) affects the expected output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an SQL test that hardcodes expected results based on today's date. The docs.testFilterToday test needs to be updated since June 2 2024, because Anneke's hire-date of 1989-06-02 (35 years ago as of time of writing) affects the expected output.
closes #109273