Harden new tsid hashing transport version#106898
Closed
dnhatn wants to merge 1 commit intoelastic:mainfrom
Closed
Conversation
dnhatn
added
>non-issue
:StorageEngine/Downsampling
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Contributor
|
I was thinking the same.. Let's also double-check with @thecoop, this needs to be backported to 8.13. |
kkrik-es
approved these changes
Mar 29, 2024
Member
Author
ldematte
requested changes
Mar 29, 2024
| public static final TransportVersion DESIRED_NODE_VERSION_OPTIONAL_STRING = def(8_580_00_0); | ||
| public static final TransportVersion ML_INFERENCE_REQUEST_INPUT_TYPE_UNSPECIFIED_ADDED = def(8_581_00_0); | ||
| public static final TransportVersion ASYNC_SEARCH_STATUS_SUPPORTS_KEEP_ALIVE = def(8_582_00_0); | ||
| public static final TransportVersion TIME_SERIES_ID_HASHING = def(8_582_10_0); |
Contributor
|
While not incorrect, I don't see that this PR is strictly necessary. The changes proposed here will eventually be effectively reverted when the transient transport versions are cleaned up - version ranges between that of values that match actual on-prem releases. And the underlying issue has been around for so long that I don't see any obvious issues related to serverless upgrades. |
Member
Author
|
Thanks everyone! |
dnhatn
removed
>non-issue
:StorageEngine/Downsampling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduced a transport version for the new tsid hash, which was missing in #98023. At the time, the latest version was
ASYNC_SEARCH_STATUS_SUPPORTS_KEEP_ALIVE = def(8_582_00_0). Therefore, I introduced a new version:TransportVersion TIME_SERIES_ID_HASHING = def(8_582_10_0). This change aims to minimize potential issues during upgrades from 8.13.0 to later versions in serverless.elasticsearch/server/src/main/java/org/elasticsearch/TransportVersions.java
Line 169 in bdd3a4f
Relates #98023
Relates #106878