Skip to content

Enable data-streams module in REST tests#106875

Merged
mosche merged 2 commits into
elastic:mainfrom
mosche:fix_datastreams_rest_tests
Mar 28, 2024
Merged

Enable data-streams module in REST tests#106875
mosche merged 2 commits into
elastic:mainfrom
mosche:fix_datastreams_rest_tests

Conversation

@mosche
Copy link
Copy Markdown
Contributor

@mosche mosche commented Mar 28, 2024

Previously the data-streams module wasn't ever present in the general REST specs.
Because of that the respective feature wasn't available causing the tests added in #105682 to be silently ignored.

We've added some validation today to make sure features are known to most recent code base (vs supported by the code running) to prevent exactly such issues.

@mosche mosche requested a review from a team as a code owner March 28, 2024 14:44
@mosche mosche requested a review from gmarouli March 28, 2024 14:44
@elasticsearchmachine elasticsearchmachine added v8.14.0 needs:triage Requires assignment of a team area label labels Mar 28, 2024
@mosche mosche added >test Issues or PRs that are addressing/adding tests :StorageEngine/Data streams Data streams and their lifecycles Team:Data Management (obsolete) DO NOT USE. This team no longer exists. and removed needs:triage Requires assignment of a team area label labels Mar 28, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Copy Markdown
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosche
Copy link
Copy Markdown
Contributor Author

mosche commented Mar 28, 2024

Thank you Mark

@mosche mosche merged commit f0b61f8 into elastic:main Mar 28, 2024
@mosche mosche deleted the fix_datastreams_rest_tests branch March 28, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:StorageEngine/Data streams Data streams and their lifecycles Team:Data Management (obsolete) DO NOT USE. This team no longer exists. >test Issues or PRs that are addressing/adding tests v8.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants