PassThroughObject nests aliases within objects for fields with dotted names#105298
Merged
kkrik-es merged 6 commits intoelastic:mainfrom Feb 9, 2024
Merged
PassThroughObject nests aliases within objects for fields with dotted names#105298kkrik-es merged 6 commits intoelastic:mainfrom
kkrik-es merged 6 commits intoelastic:mainfrom
Conversation
Collaborator
|
Hi @kkrik-es, I've created a changelog YAML for you. |
kkrik-es
changed the title
kkrik-es
changed the title
kkrik-es
changed the title
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Feb 9, 2024
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
Maybe add a yaml test that simulated what the Kibana tests were doing? Otherwise LGTM.
| pr: 105298 | ||
| summary: Ignore duplicate `FieldAliasMappers` | ||
| area: TSDB | ||
| type: bug |
Member
There was a problem hiding this comment.
This is a bug in unreleased code, let's mark it as non-issue and then a changelog isn't needed.
Member
Author
Let's do this in a follow-up change, to avoid delaying this one. There's coverage for this in the 150_tsdb.yml test, we do need more tests outside the passthrough object. |
kkrik-es
added
the
auto-merge-without-approval
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Unskips tests that were skipped due to an upstream change and fixed in elastic/elasticsearch#105298 Addresses elastic#176105, elastic#176117, elastic#176270, elastic#176359, elastic#176360
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary Unskips tests that were skipped due to an upstream change and fixed in elastic/elasticsearch#105298 Addresses elastic#176105, elastic#176117, elastic#176270, elastic#176359, elastic#176360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #103648 that introduced PassThroughObject, ObjectMapper was modified to use the full name for FieldAliasMappers, so that aliases at the root level can contain dots. This led to a regression reported in Kibana tests where aliases were wrongly reported as duplicates. The culprit is that aliases with names containing dots were directly added under the root object, instead of being nested within objects. This change restores the right behavior.
Related to #103567