Efficiently encode multi-valued dimensions#105271
Merged
elasticsearchmachine merged 11 commits intoelastic:mainfrom Feb 8, 2024
Merged
Efficiently encode multi-valued dimensions#105271elasticsearchmachine merged 11 commits intoelastic:mainfrom
elasticsearchmachine merged 11 commits intoelastic:mainfrom
Conversation
This is beneficial for encoding dimensions that are multivalued, such as host.ip.
elasticsearchmachine
added
Team:StorageEngine
external-contributor
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
felixbarny
commented
Feb 8, 2024
server/src/test/java/org/elasticsearch/index/codec/tsdb/ES87TSDBDocValuesEncoderTests.java
Show resolved
Hide resolved
felixbarny
changed the title
Collaborator
|
Hi @felixbarny, I've created a changelog YAML for you. |
martijnvg
reviewed
Feb 8, 2024
jpountz
reviewed
Feb 8, 2024
server/src/main/java/org/elasticsearch/index/codec/tsdb/ES87TSDBDocValuesEncoder.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/codec/tsdb/ES87TSDBDocValuesEncoder.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/codec/tsdb/ES87TSDBDocValuesEncoder.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/codec/tsdb/ES87TSDBDocValuesEncoder.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/codec/tsdb/ES87TSDBDocValuesEncoder.java
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/codec/tsdb/ES87TSDBDocValuesEncoderTests.java
Show resolved
Hide resolved
martijnvg
reviewed
Feb 8, 2024
Member
There was a problem hiding this comment.
I think we also need to update the PerFieldMapperCodec#useTSDBDocValuesFormat(...) to take IpFieldMapper class into account for when to enable to codec. Otherwise we don't see any improvements for ip fields.
Ideally we should not use the MapperService in order to determine whether the codec needs to be enabled. We should check FieldInfo and enable it if doc values type is: sorted, sorted set, numeric and sorted numeric. Then we really catch all cases. For example for ScaledFieldMapper this codec isn't enabled today, while it should. I can do this in another PR. It would add (positive) noise to the benchmark result, if we made this change in this PR.
Member
Author
|
Thanks for the reviews, they were super helpful ❤️ |
Member
Field by field comparison between main (baseline) and this PR (contender)
Note that |
jpountz
approved these changes
Feb 8, 2024
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
I left minor comments, otherwise LGTM!
server/src/main/java/org/elasticsearch/index/codec/tsdb/ES87TSDBDocValuesEncoder.java
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/codec/tsdb/ES87TSDBDocValuesEncoderTests.java
Show resolved
Hide resolved
felixbarny
added
the
auto-merge-without-approval
jpountz
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detects and efficiently encodes cyclic ordinals, as proposed by @jpountz. This is beneficial for encoding dimensions that are multivalued, such as host.ip.
A follow-up on #99747