Nest pass-through objects within objects#105062
Merged
kkrik-es merged 9 commits intoelastic:mainfrom Feb 5, 2024
Merged
Conversation
kkrik-es
added
>enhancement
:StorageEngine/TSDB
Collaborator
|
Hi @kkrik-es, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
felixbarny
approved these changes
Feb 2, 2024
Member
felixbarny
left a comment
felixbarny
left a comment
There was a problem hiding this comment.
Just one idea for an additional case to test. Otherwise LGTM!
| } | ||
|
|
||
| public void testPassThroughObjectNested() throws IOException { | ||
| MapperService mapperService = createMapperService(mapping(b -> { |
Member
There was a problem hiding this comment.
In the same test case, could you also add a top level attributes passthrough field? Just to check that this doesn’t cause a naming conflict because there’s also an attributes field in the resource object.
Member
Author
There was a problem hiding this comment.
Done, had a test for that in yaml too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #103648, lifting the limitation that pass-through objects need to be defined at the root level.
Pass-through objects still need to be "leaf" fields, they can't have child objects.
Related to #103567