Changing ReplicationRequestBuilder to be an ActionRequestLazyBuilder#104956
Closed
masseyke wants to merge 2 commits intoelastic:mainfrom
Closed
Changing ReplicationRequestBuilder to be an ActionRequestLazyBuilder#104956masseyke wants to merge 2 commits intoelastic:mainfrom
masseyke wants to merge 2 commits intoelastic:mainfrom
Conversation
masseyke
added
>enhancement
:Distributed/Ingest Node
elasticsearchmachine
added
the
Team:Data Management (obsolete)
Collaborator
|
Hi @masseyke, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #104778 and #104927 by switching ReplicationRequestBuilder from being an ActionRequestBuilder to being an ActionRequestLazyBuilder. This also means porting over its two subclasses -- IndexRequestBuilder and DeleteRequestBuilder.
Note: I'm converting this to a draft because I forgot that ReindexRequestBuilder is tangled up with IndexRequestBuilder. I'm leaving it open as a draft for discussion about the classes that have changed here, but once that is settled I will roll this into a PR that changes ReindexRequestBuilder as well.