Skip to content

Introduce ChunkedLoggingStreamTestUtils#104835

Merged
elasticsearchmachine merged 3 commits intoelastic:mainfrom
DaveCTurner:2024/01/27/ChunkedLoggingStreamTestUtils
Jan 29, 2024
Merged

Introduce ChunkedLoggingStreamTestUtils#104835
elasticsearchmachine merged 3 commits intoelastic:mainfrom
DaveCTurner:2024/01/27/ChunkedLoggingStreamTestUtils

Conversation

@DaveCTurner
Copy link
Copy Markdown
Member

Today the test utilities for extracting data logged by a
ChunkedLoggingStream are in the :server test suite which renders
them inaccessible to the test suites of other modules. This commit moves
them to :test:framework.

Today the test utilities for extracting data logged by a
`ChunkedLoggingStream` are in the `:server` test suite which renders
them inaccessible to the test suites of other modules. This commit moves
them to `:test:framework`.
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Core/Infra/Logging Log management and logging utilities v8.13.0 labels Jan 27, 2024
@DaveCTurner DaveCTurner requested a review from ywangd January 27, 2024 13:37
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jan 27, 2024
Copy link
Copy Markdown
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 29, 2024
@elasticsearchmachine elasticsearchmachine merged commit 368322e into elastic:main Jan 29, 2024
@DaveCTurner DaveCTurner deleted the 2024/01/27/ChunkedLoggingStreamTestUtils branch January 29, 2024 09:40
@DaveCTurner
Copy link
Copy Markdown
Member Author

FWIW this was opened to prepare things for #104851.

@DaveCTurner DaveCTurner restored the 2024/01/27/ChunkedLoggingStreamTestUtils branch June 17, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Logging Log management and logging utilities Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.13.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants