Dedicated logger for Netty4HttpPipeliningHandler#104806
Merged
elasticsearchmachine merged 1 commit intoelastic:mainfrom Jan 26, 2024
Merged
Conversation
Better to use a logger for the class that's doing the logging rather than deferring back to the owning transport's logger.
DaveCTurner
added
>non-issue
:Distributed/Network
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
pxsalehi
approved these changes
Jan 26, 2024
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
deleted the
2024/01/26/Netty4HttpPipeliningHandler-static-logger
branch
Member
Author
|
FWIW this was opened to prepare things for #104851. |
DaveCTurner
restored the
2024/01/26/Netty4HttpPipeliningHandler-static-logger
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better to use a logger for the class that's doing the logging rather
than deferring back to the owning transport's logger.