Internal: Explicitely opt-out for the Lucene query cache. #10462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the default query cache is not on by default, it might change in the future so we should opt out as it would not play well with NoCacheFilter (which we should aim at removing).
Contributor
|
don't think this catches all the places creating indexsearchers. For example ChildrenConstantScoreQuery |
Contributor
Author
|
Good point, it looks like we have lots of code that instantiate IndexSearcher instances actually. :( |
Contributor
Author
|
Hmm, closing as a won't fix then. |
bizybot
pushed a commit
to bizybot/elasticsearch
that referenced
this pull request
May 1, 2019
Infra has fixed elastic#10462 by installing `haveged` on CI workers. This commit enables the disabled fixture and tests, and mounts `/dev/urandom` for the container so there is enough entropy required for kdc. Closes elastic#40624
bizybot
added a commit
to bizybot/elasticsearch
that referenced
this pull request
Jun 13, 2019
elastic#41710) Infra has fixed elastic#10462 by installing `haveged` on CI workers. This commit enables the disabled fixture and tests, and mounts `/dev/urandom` for the container so there is enough entropy required for kdc. Note: hdfs-repository tests have been disabled, will raise a separate issue for it. Closes elastic#40624 Closes elastic#40678
bizybot
added a commit
to bizybot/elasticsearch
that referenced
this pull request
Jun 13, 2019
elastic#41710) Infra has fixed elastic#10462 by installing `haveged` on CI workers. This commit enables the disabled fixture and tests, and mounts `/dev/urandom` for the container so there is enough entropy required for kdc. Note: hdfs-repository tests have been disabled, will raise a separate issue for it. Closes elastic#40624 Closes elastic#40678
bizybot
added a commit
to bizybot/elasticsearch
that referenced
this pull request
Jun 13, 2019
elastic#41710) Infra has fixed elastic#10462 by installing `haveged` on CI workers. This commit enables the disabled fixture and tests, and mounts `/dev/urandom` for the container so there is enough entropy required for kdc. Note: hdfs-repository tests have been disabled, will raise a separate issue for it. Closes elastic#40624 Closes elastic#40678
This was referenced Jun 13, 2019
bizybot
added a commit
to bizybot/elasticsearch
that referenced
this pull request
Jun 13, 2019
elastic#41710) Infra has fixed elastic#10462 by installing `haveged` on CI workers. This commit enables the disabled fixture and tests, and mounts `/dev/urandom` for the container so there is enough entropy required for kdc. Note: hdfs-repository tests have been disabled, will raise a separate issue for it. Closes elastic#40624 Closes elastic#40678
bizybot
added a commit
to bizybot/elasticsearch
that referenced
this pull request
Jun 13, 2019
elastic#41710) Infra has fixed elastic#10462 by installing `haveged` on CI workers. This commit enables the disabled fixture and tests, and mounts `/dev/urandom` for the container so there is enough entropy required for kdc. Note: hdfs-repository tests have been disabled, will raise a separate issue for it. Closes elastic#40624 Closes elastic#40678
bizybot
added a commit
that referenced
this pull request
Jun 13, 2019
#41710) (#43179) Infra has fixed #10462 by installing `haveged` on CI workers. This commit enables the disabled fixture and tests, and mounts `/dev/urandom` for the container so there is enough entropy required for kdc. Note: hdfs-repository tests have been disabled, will raise a separate issue for it. Closes #40624 Closes #40678
bizybot
added a commit
that referenced
this pull request
Jun 13, 2019
#41710) (#43178) Infra has fixed #10462 by installing `haveged` on CI workers. This commit enables the disabled fixture and tests, and mounts `/dev/urandom` for the container so there is enough entropy required for kdc. Note: hdfs-repository tests have been disabled, will raise a separate issue for it. Closes #40624 Closes #40678
bizybot
added a commit
that referenced
this pull request
Jun 13, 2019
#41710) (#43180) Infra has fixed #10462 by installing `haveged` on CI workers. This commit enables the disabled fixture and tests, and mounts `/dev/urandom` for the container so there is enough entropy required for kdc. Note: hdfs-repository tests have been disabled, will raise a separate issue for it. Closes #40624 Closes #40678
bizybot
added a commit
that referenced
this pull request
Jun 13, 2019
#41710) (#43181) Infra has fixed #10462 by installing `haveged` on CI workers. This commit enables the disabled fixture and tests, and mounts `/dev/urandom` for the container so there is enough entropy required for kdc. Note: hdfs-repository tests have been disabled, will raise a separate issue for it. Closes #40624 Closes #40678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the default query cache is not on by default, it might change in
the future so we should opt out as it would not play well with NoCacheFilter
(which we should aim at removing).