Extract HotThreads#logLocalHotThreads utility #103253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since elastic#93458 we capture and log the local node's hot threads when something is holding on to a shard lock for longer than expected. In fact there's various other reasons we might want to automatically capture and log the local node's hot threads. This commit extracts a utility method to do this.
DaveCTurner
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
approved these changes
Dec 11, 2023
Contributor
ldematte
left a comment
ldematte
left a comment
There was a problem hiding this comment.
LGTM
I like that you added checking the logger level based on the level passed, and not fixed at debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #93458 we capture and log the local node's hot threads when
something is holding on to a shard lock for longer than expected. In
fact there's various other reasons we might want to automatically
capture and log the local node's hot threads. This commit extracts a
utility method to do this.