Fix incorrect dynamic mapping for non-numeric-value arrays #101965#101967
Merged
benwtrent merged 3 commits intoelastic:mainfrom Nov 9, 2023
Merged
Fix incorrect dynamic mapping for non-numeric-value arrays #101965#101967benwtrent merged 3 commits intoelastic:mainfrom
benwtrent merged 3 commits intoelastic:mainfrom
Conversation
benwtrent
added
>bug
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Collaborator
|
Hi @benwtrent, I've created a changelog YAML for you. |
benwtrent
added
the
auto-backport
Collaborator
💚 Backport successful
|
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Nov 9, 2023
…1965 (elastic#101967) After elastic#98512 we incorrectly attempt to map an array of any single value type to dense_vector. Instead, we should validate that ALL mappers are numeric and that ALL of them are `float`. closes: elastic#101965
benwtrent
added a commit
that referenced
this pull request
Nov 9, 2023
…1965 (#101967) (#101975) * Fix incorrect dynamic mapping for non-numeric-value arrays #101965 (#101967) After #98512 we incorrectly attempt to map an array of any single value type to dense_vector. Instead, we should validate that ALL mappers are numeric and that ALL of them are `float`. closes: #101965 * Update rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.vectors/60_dense_vector_dynamic_mapping.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #98512 we incorrectly attempt to map an array of any single value type to dense_vector.
Instead, we should validate that ALL mappers are numeric and that ALL of them are
float.closes: #101965