Skip to content

Exclude synthetic source test for TSDB from mixedClusterTests #100592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 11, 2023
Merged

Exclude synthetic source test for TSDB from mixedClusterTests #100592

merged 12 commits into from
Oct 11, 2023

Conversation

kkrik-es
Copy link
Contributor

@kkrik-es kkrik-es commented Oct 10, 2023 •
edited
Loading

We suspect the synthetic source test for tsdb mappings that was added in #98808 may be contributing to flakiness in mixed cluster tests.

This change also reverts #100572 since it doesn't work as expected - see comment below.

Fixes #100562

@kkrik-es
Don't print synthetic source in mapping for bwc tests
78734b9
@kkrik-es
Move comment.
89641ee
@kkrik-es
Don't print synthetic source in mapping for bwc tests elastic#2
44e8156
@kkrik-es
Don't print synthetic source in mapping for bwc tests elastic#2
034262c
@kkrik-es
Merge branch 'main' into fix/100562
4cf0605 
# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/SourceFieldMapper.java
#	server/src/test/java/org/elasticsearch/index/mapper/SourceFieldMapperTests.java
#	server/src/test/java/org/elasticsearch/index/query/SearchExecutionContextTests.java
@kkrik-es kkrik-es added >test Issues or PRs that are addressing/adding tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :StorageEngine/TSDB You know, for Metrics labels Oct 10, 2023
@kkrik-es kkrik-es self-assigned this Oct 10, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@kkrik-es kkrik-es requested a review from martijnvg October 10, 2023 13:10
@martijnvg martijnvg added the test-full-bwc Trigger full BWC version matrix tests label Oct 10, 2023
martijnvg
martijnvg approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but let's run full bwc tests before merging?

@kkrik-es
Copy link
Contributor Author

kkrik-es commented Oct 10, 2023 •
edited
Loading

Wow this made all the bwc tests between 8.7 and 8.10 to fail.. I'm dropping it.

Screenshot 2023-10-10 at 5 59 16 PM

@kkrik-es kkrik-es changed the title Don't print synthetic source in mapping for bwc tests (part 2) Exclude synthetic source test for TSDB from mixedClusterTests Oct 11, 2023
martijnvg
martijnvg approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kkrik-es kkrik-es merged commit 24037d6 into elastic:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martijnvg martijnvg martijnvg approved these changes

Assignees

@kkrik-es kkrik-es

Labels

:StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests test-full-bwc Trigger full BWC version matrix tests v8.12.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] MixedClusterClientYamlTestSuiteIT classMethod failing

3 participants

@kkrik-es @elasticsearchmachine @martijnvg