Skip to content

Fix BreakingBytesRefBuilderTests testGrow failing #100547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fix BreakingBytesRefBuilderTests testGrow failing #100547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...ompute/src/test/java/org/elasticsearch/compute/operator/BreakingBytesRefBuilderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ public void applyToOracle(BytesRefBuilder oracle) {
});
}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/99649")
public void testAddBytesRef() {
testAgainstOracle(() -> new TestIteration() {
BytesRef ref = new BytesRef(randomAlphaOfLengthBetween(1, 100));
Expand All @@ -73,7 +72,6 @@ public void applyToOracle(BytesRefBuilder oracle) {
});
}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/99649")
public void testGrow() {
testAgainstOracle(() -> new TestIteration() {
int length = between(1, 100);
Expand Down Expand Up @@ -123,7 +121,7 @@ private void testAgainstOracle(Supplier<TestIteration> iterations) {
boolean willResize = builder.length() + iteration.size() >= builder.bytes().length;
if (willResize) {
long resizeMemoryUsage = BreakingBytesRefBuilder.SHALLOW_SIZE + ramForArray(builder.bytes().length);
resizeMemoryUsage += ramForArray(ArrayUtil.oversize(builder.bytes().length + iteration.size(), Byte.BYTES));
resizeMemoryUsage += ramForArray(ArrayUtil.oversize(builder.length() + iteration.size(), Byte.BYTES));
if (resizeMemoryUsage > limit) {
Exception e = expectThrows(CircuitBreakingException.class, () -> iteration.applyToBuilder(builder));
assertThat(e.getMessage(), equalTo("over test limit"));
Expand Down