Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCE when re-throwing "shard not available" exception in TransportShardMultiGetAction #32173

Closed
sabi0 opened this issue Jul 18, 2018 · 6 comments · Fixed by #32185
Closed

CCE when re-throwing "shard not available" exception in TransportShardMultiGetAction #32173

sabi0 opened this issue Jul 18, 2018 · 6 comments · Fixed by #32185
Labels
>bug :Core/Infra/Core Core issues without another label good first issue low hanging fruit help wanted adoptme

Comments

@sabi0
Copy link
Contributor

sabi0 commented Jul 18, 2018

elasticsearch/server/src/main/java/org/elasticsearch/action/get/TransportShardMultiGetAction.java

Line 95 in cfb3014

throw (ElasticsearchException) e;

TransportActions.isShardNotAvailableException() is also true for Lucene's AlreadyClosedException, which is not ElasticsearchException sub-class.
When that happens CCE will be thrown instead of re-throwing the actual exception.
@dnhatn dnhatn added >bug :Core/Infra/Core Core issues without another label labels Jul 18, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@dnhatn dnhatn added good first issue low hanging fruit help wanted adoptme labels Jul 18, 2018
@ashokn
Copy link

ashokn commented Jul 19, 2018 •
edited
Loading

I would like to work on this issue

itsnotv pushed a commit to itsnotv/elasticsearch that referenced this issue Jul 19, 2018
fixes elastic#32173
500c120
@itsnotv
Copy link
Contributor

itsnotv commented Jul 19, 2018 •
edited
Loading

@ashokn missed your comment and submitted a PR #32185.

@sabi0 @dnhatn let me know if my change is fine.

@itsnotv itsnotv mentioned this issue Jul 19, 2018
Merged
@sabi0
Copy link
Contributor Author

sabi0 commented Jul 19, 2018

Searching for usages of isShardNotAvailableException reveals a couple more places in the code with the same problem: TransportShardMultiPercolateAction, TransportShardMultiTermsVectorAction.

@itsnotv
Copy link
Contributor

itsnotv commented Jul 19, 2018

@sabi0 I can't find TransportShardMultiPercolateAction in master, I have fixed for TransportShardMultiTermsVectorAction.

@sabi0
Copy link
Contributor Author

sabi0 commented Jul 19, 2018 •
edited
Loading

@itsnotv Sorry, I was looking at an older version of the source. There isn't TransportShardMultiPercolateAction in master anymore, indeed.

bleskes pushed a commit that referenced this issue Jul 23, 2018
@itsnotv @bleskes
CCE when re-throwing "shard not available" exception in TransportShar…
4b3284f 
…dMultiGetAction (#32185)

ClassCastException can be thrown by callers of TransportActions.isShardNotAvailableException(e) as e is not always an instance of ElasticSearchException

fixes #32173
bleskes pushed a commit that referenced this issue Jul 23, 2018
@itsnotv @bleskes
CCE when re-throwing "shard not available" exception in TransportShar…
1eec6a0 
…dMultiGetAction (#32185)

ClassCastException can be thrown by callers of TransportActions.isShardNotAvailableException(e) as e is not always an instance of ElasticSearchException

fixes #32173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Core/Infra/Core Core issues without another label good first issue low hanging fruit help wanted adoptme
Projects
None yet
Milestone
No milestone
5 participants
@ashokn @itsnotv @sabi0 @dnhatn @elasticmachine