update examples with latest request-converter#5865
Conversation
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
|
could we merge #5780 before? I've fixed some examples |
ac7d919 to
723b07a
Compare
|
This PR is now updated. I noticed that at some point the examples were re-generated with an older request converter, because a bunch of them are incorrect. These are all fixed in this PR as well. |
| const java = new JavaCaller({ | ||
| minimumJavaVersion: 21, | ||
| jar: "path/to/converter/jar/java-es-request-converter-1.0-SNAPSHOT.jar", | ||
| jar: process.env.JAVA_ES_REQUEST_CONVERTER_JAR, |
There was a problem hiding this comment.
Once we merge the Java PR in the request converter we will be able to remove the JavaCaller code and run the Java conversions in the same way as the other languages.
|
@miguelgrinberg LGTM, but are we ready to merge the other PR? |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-5865-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5e0cd0e8ce2c2132227dcebca0d777227419400f
# Push it to GitHub
git push --set-upstream origin backport-5865-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.3 9.3
# Navigate to the new working tree
cd .worktrees/backport-9.3
# Create a new branch
git switch --create backport-5865-to-9.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5e0cd0e8ce2c2132227dcebca0d777227419400f
# Push it to GitHub
git push --set-upstream origin backport-5865-to-9.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.3Then, create a pull request where the |
This PR refreshes all the language code examples. To ensure that always the latest request-converter is used for this task, I've also added an
npm update @elastic/request-converterto themake generate-language-examplestask.