Add spec for project routing CRUD REST API endpoints#5860
Add spec for project routing CRUD REST API endpoints#5860alexey-ivanov-es merged 6 commits intomainfrom
Conversation
|
Following you can find the validation changes against the target branch for the APIs.
You can validate these APIs yourself by using the |
flobernd
left a comment
There was a problem hiding this comment.
Looks good, thank you 🙂 Just a few minor questions/comments.
| * under the License. | ||
| */ | ||
|
|
||
| export class ProjectRoutingExpression { |
There was a problem hiding this comment.
Is this class named the same in the Elasticsearch code base? I personally would have used ProjectRouting as the class name since the expression is only a part of it, but if it's the same in Elasticsearch, let's keep it as is 🙂
There was a problem hiding this comment.
I'm looking at the server code (in serverless) and it seems like every class there is actually called SomethingProjectRoutingExpression, so I'd actually argue all other endpoint classes should be named as closely as possible to what's in the server code
There was a problem hiding this comment.
In the server code it is SavedProjectRoutingExpression, but I think Saved prefix would be confusing in API
There was a problem hiding this comment.
agree for Saved, I'd keep Expression though
specification/project_routing/create_single/CreateRoutingRequest.ts
Outdated
Show resolved
Hide resolved
|
FYI These APIs are now documented here: https://www.elastic.co/docs/api/doc/elasticsearch-serverless/group/endpoint-project |
Elasticsearch PR: elastic/elasticsearch#139634