Drop project_routing from query parameters#5835
Conversation
pawankartik-elastic
added
specification
skip-backport
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
output/schema/validation-errors.json
Outdated
| }, | ||
| "async_search.submit": { | ||
| "request": [ | ||
| "Request: missing json spec query parameter 'project_routing'" |
There was a problem hiding this comment.
I don't understand what this file is reporting here.
There was a problem hiding this comment.
This is exactly why I asked you what commands you ran. I see similar changes in your PR as well, and I wasn't really sure what's all this about.
There was a problem hiding this comment.
This file no longer shows up in the diff after my recent branch update and commits. I believe it's all ok now? I re-ran the commands we use to check if I forgot to check it in after any changes, and that's not the case — all the files are checked in and up-to-date.
| * Supported in serverless only. | ||
| * @availability serverless stability=stable visibility=feature_flag feature_flag=serverless.cross_project.enabled | ||
| */ | ||
| project_routing?: ProjectRouting |
There was a problem hiding this comment.
I don't see project_routing in the body for EQL or SQL, but I'm pretty sure support for them was added in the code. @luigidellaquila is that right?
If yes, @pawankartik-elastic, can you add those here?
There was a problem hiding this comment.
Done. I've added them.
2 participants
ES-13725: We previously assumed that
project_routingcould appear either as a query parameter or within the request body. Now that we restrict it to just the request body, this PR makes the suitable adjustments within the specs.