Add missing query parameter for CreateRequest#3954
Merged
Conversation
2 tasks
Contributor
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
l-trotta
approved these changes
Mar 13, 2025
Contributor
l-trotta
left a comment
l-trotta
left a comment
There was a problem hiding this comment.
server code for future references - LGTM!
Member
Author
|
Thanks for the review! I had linked the server code in the description |
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
(cherry picked from commit bb844d6)
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
(cherry picked from commit bb844d6)
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
(cherry picked from commit bb844d6)
pquentin
added a commit
that referenced
this pull request
Mar 14, 2025
pquentin
added a commit
that referenced
this pull request
Mar 14, 2025
pquentin
added a commit
that referenced
this pull request
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As defined in RestIndexAction.
Not backporting to 8.17 because of elastic/elasticsearch#120725.
This was noticed by @afharo in https://github.com/elastic/kibana/pull/213375/files#r1984114255.