-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elasticsearch::Client unexpectedly modifies parameters during search #1727
Comments
Hi @j-bennet, |
picandocodigo
added a commit
that referenced
this issue
Mar 24, 2022
When updating the code generator for 8.x, the order of `arguments.clone` in the generated code was changed. This would make it so that we would modify the arguments before cloning them, which is undesired. Addresses #1727
picandocodigo
added a commit
that referenced
this issue
Mar 24, 2022
When updating the code generator for 8.x, the order of `arguments.clone` in the generated code was changed. This would make it so that we would modify the arguments before cloning them, which is undesired. Addresses #1727
picandocodigo
added a commit
that referenced
this issue
Mar 24, 2022
When updating the code generator for 8.x, the order of `arguments.clone` in the generated code was changed. This would make it so that we would modify the arguments before cloning them, which is undesired. Addresses #1727
picandocodigo
added a commit
that referenced
this issue
Mar 29, 2022
When updating the code generator for 8.x, the order of `arguments.clone` in the generated code was changed. This would make it so that we would modify the arguments before cloning them, which is undesired. Addresses #1727
picandocodigo
added a commit
that referenced
this issue
Mar 29, 2022
When updating the code generator for 8.x, the order of `arguments.clone` in the generated code was changed. This would make it so that we would modify the arguments before cloning them, which is undesired. Addresses #1727
picandocodigo
added a commit
that referenced
this issue
Mar 29, 2022
When updating the code generator for 8.x, the order of `arguments.clone` in the generated code was changed. This would make it so that we would modify the arguments before cloning them, which is undesired. Addresses #1727
picandocodigo
added a commit
that referenced
this issue
Mar 29, 2022
When updating the code generator for 8.x, the order of `arguments.clone` in the generated code was changed. This would make it so that we would modify the arguments before cloning them, which is undesired. Addresses #1727
picandocodigo
added a commit
that referenced
this issue
Apr 4, 2022
When updating the code generator for 8.x, the order of `arguments.clone` in the generated code was changed. This would make it so that we would modify the arguments before cloning them, which is undesired. Addresses #1727
@j-bennet have you had a chance to test the latest releases? Is it ok to close this issue now? |
Yes, this seems to be fixed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When calling
search
method ofElasticsearch::Client
and passing in a dict of parameters, parameters are unexpectedly modified. Here is a minimal example:Output:
If I needed my params after, this is breaking behavior.
The behavior changed between 7.17 and 8.0.
The text was updated successfully, but these errors were encountered: