Fix pre 7.2 endpoint class name with aliases + reapply fix #947 #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thePanz
reviewed
Nov 20, 2019
src/autoload.php
Outdated
| class_alias('\Elasticsearch\Endpoints\GetSource', '\Elasticsearch\Endpoints\Source\Get'); | ||
| class_alias('\Elasticsearch\Endpoints\ExistsSource', '\Elasticsearch\Endpoints\Source\Exists'); | ||
| class_alias('\Elasticsearch\Endpoints\Tasks\ListTasks', '\Elasticsearch\Endpoints\Tasks\TasksList'); | ||
| class_alias('\Elasticsearch\Endpoints\Termvectors', '\Elasticsearch\Endpoints\TermVectors'); |
There was a problem hiding this comment.
The alias is not needed, same name on both sides
There was a problem hiding this comment.
Case has changed. But I'm not sure if class names are case sensitive.
There was a problem hiding this comment.
@thePanz is right here. The alias cannot be done for case sensitive, since classes are case insensitive in PHP (even if the autoloading of composer is case sensitive). I'll just reuse the old class naming convention here.
deguif
approved these changes
Nov 20, 2019
deguif
reviewed
Nov 25, 2019
| */ | ||
|
|
||
| class_alias('\Elasticsearch\Endpoints\Nodes\Info', '\Elasticsearch\Endpoints\Cluster\Nodes\Info'); | ||
| class_alias('\Elasticsearch\Endpoints\Nodes\Stats', '\Elasticsearch\Endpoints\Cluster\Nodes\Stats'); |
There was a problem hiding this comment.
What about previous classes:
Elasticsearch\Endpoints\Cluster\Nodes\HotThreadsElasticsearch\Endpoints\Cluster\Nodes\UsageElasticsearch\Endpoints\Cluster\Nodes\ReloadSecureSettings
There was a problem hiding this comment.
You right, just added it. Thanks for this code review!
deguif
approved these changes
Nov 25, 2019
This was referenced Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #967 introducing a class alias to all the previous endpoint namespaces present in
elasticsearch-php 7.2.I generated the class name for all the endpoints in 7.2 branch and I produced an alias in
src/autoload.php(I removed the outdated endpoints, not available anymore in Elasticsearch 7).I added the autoload.php file in composer.
NOTE: This file will be removed in the next major version (8.0.0).
I also reapplied the fix #947 for
IndicesNamespace::getAliases().