Fix prependMissingScheme with underscore #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihor-sviziev
changed the title
ihor-sviziev
force-pushed
the
patch-1
branch
from
83dfa46 to
9c6e356
Compare
|
Thanks @ihor-sviziev, good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with ElasticSearch in docker using docker-compose - hostname for my ES was
elasticsearch.myproject_default. I tried to use it with this ES client - it failed to connect.I configured hostname to
http://elasticsearch.myproject_default:9200. After changing toelasticsearch.myproject_default:9200my issue was fixed, but that wasn't expected at allDeeper investigation showed that issue caused by incorrect URL validation. More info: https://stackoverflow.com/questions/39539468/php-filter-validate-url-not-finding-subdomains-with-underscore