Missing Implementation for Doc Examples

[philkra]

The Get API page had a missing implementation for the put mapping code snippet.

[ezimuel]

The only concern that I have is about the naming of the class Elasticsearch\Examples\Docs\Docs\Get. Why this is Get if there are examples with Put, Head, etc? Apart from that, LGTM.

[philkra]

Yes, it bothers me as well! Let me rework this to append a Page to every class name, e.g. GetPage. Or do you have a better suggestion for semantically reasonable naming suffix?

[ezimuel]

Proposal: use the same naming convention that we have for the endpoints. We will have small classes (unit tests) for each endpoint and this will also facilitate the search for examples. @philkra what do you think?

[ezimuel]

We discussed in a meeting with @philkra and it's ok for me to follow the actual naming convention for the doc examples. LGTM!