Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #902 Incorrect return typehint when using async requests #905

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Fix #902 Incorrect return typehint when using async requests #905

merged 1 commit into from
Jul 1, 2019

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Jun 28, 2019

This PR fixes #902 removing the typehint array from Client::performRequest().
It includes also a unit test for reproduction the issue.

@ezimuel ezimuel mentioned this pull request Jun 28, 2019
Closed
@ezimuel ezimuel requested a review from philkra June 28, 2019 14:04
@ezimuel ezimuel added this to the 7.0.2 milestone Jun 28, 2019
@ezimuel ezimuel added the bug label Jun 28, 2019
philkra
philkra approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ezimuel ezimuel merged commit cf1bf4d into elastic:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philkra philkra philkra approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.

Incorrect return typehint when using async requests / futures
2 participants
@ezimuel @philkra