-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs update for Elasticsearch 7 #904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezimuel
changed the title
Docs update to Elasticsearch 7
Docs update for Elasticsearch 7
Jun 27, 2019
szabosteve
reviewed
Jun 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added four minor suggestions. I hope they are useful.
Co-Authored-By: István Zoltán Szabó <[email protected]>
Co-Authored-By: István Zoltán Szabó <[email protected]>
Co-Authored-By: István Zoltán Szabó <[email protected]>
Co-Authored-By: István Zoltán Szabó <[email protected]>
szabosteve
approved these changes
Jun 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation for Elasticsearch 7. We removed the usage of
type
in the documentation and in the examples.Moreover, this PR includes a small fix for
getSource
endpoint, discovered during the documentation update.Thanks to @philkra for the initial commits!