Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update for Elasticsearch 7 #904

Merged
merged 8 commits into from
Jun 27, 2019
Merged

Docs update for Elasticsearch 7 #904

merged 8 commits into from
Jun 27, 2019

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Jun 27, 2019

This PR updates the documentation for Elasticsearch 7. We removed the usage of type in the documentation and in the examples.
Moreover, this PR includes a small fix for getSource endpoint, discovered during the documentation update.

Thanks to @philkra for the initial commits!

@ezimuel ezimuel changed the title Docs update to Elasticsearch 7 Docs update for Elasticsearch 7 Jun 27, 2019
@ezimuel ezimuel requested review from lcawl and szabosteve June 27, 2019 12:52
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added four minor suggestions. I hope they are useful.

README.md Outdated Show resolved Hide resolved
docs/quickstart.asciidoc Outdated Show resolved Hide resolved
docs/quickstart.asciidoc Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ezimuel and others added 4 commits June 27, 2019 15:42
Co-Authored-By: István Zoltán Szabó <[email protected]>
Co-Authored-By: István Zoltán Szabó <[email protected]>
Co-Authored-By: István Zoltán Szabó <[email protected]>
Co-Authored-By: István Zoltán Szabó <[email protected]>
@ezimuel ezimuel removed the request for review from lcawl June 27, 2019 13:44
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ezimuel ezimuel merged commit 9176508 into master Jun 27, 2019
@philkra philkra deleted the docs-review branch February 20, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants