Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Connection.php #734

Closed
wants to merge 1 commit into from
Closed

Conversation

ankushgup2a
Copy link

These changes are imported from :
Fix parsing of NodesInfo for Sniffing
Closes #629 and #648
for sniffing to work properly.

c0ed43c

These changes are imported from :
Fix parsing of NodesInfo for Sniffing
Closes elastic#629 and elastic#648
for sniffing to work properly.

elastic@c0ed43c
@polyfractal
Copy link
Contributor

Two things:

  • Elasticsearch 2.x is no longer maintained, which extends to the clients too. We won't be making any serious changes to ES-PHP 2.x anymore.
  • That said, I'd be willing to backport the change because it should be reasonably small. But it looks like your PR is just for a small portion of the original PR, did you intend to do that?

@ankushgup2a
Copy link
Author

ankushgup2a commented Apr 4, 2018 via email

@polyfractal
Copy link
Contributor

Sounds good, thanks :) Closing this PR

@polyfractal polyfractal closed this Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants